Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Change docs:start script to serve the exports folder #43375

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 20, 2024

Change the production start command to statically serve the export folder. The next start command doesn't work with static export.

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Aug 20, 2024
@mui-bot
Copy link

mui-bot commented Aug 20, 2024

Netlify deploy preview

https://deploy-preview-43375--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 78e013f

@Janpot Janpot changed the title [code-infra] Change docs:start script [code-infra] Change docs:start script to serve the exports folder Aug 20, 2024
@Janpot Janpot marked this pull request as ready for review August 20, 2024 08:49
@Janpot
Copy link
Member Author

Janpot commented Aug 20, 2024

codecov issue seems to be on their end. Both uploads have started, but only one is marked as successful https://app.codecov.io/github/mui/material-ui/commit/78e013f85b654ac6aaeb8dd8946690bf72503fd8
I can see the uploaded file, it looks like something goes wrong in their end.

@Janpot Janpot merged commit 576d1a7 into mui:next Aug 21, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants