[codemod] Skip sx spread transformation #43291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43291--material-ui.netlify.app/ Bundle size report |
siriwatknp
added
bug 🐛
LukasTy
reviewed
Aug 14, 2024
Comment on lines
+343
to
+346
| (data.node.argument.test.type === 'CallExpression' && | ||
| data.node.argument.test.callee.type === 'MemberExpression' && | ||
| data.node.argument.test.callee.object.name === 'Array' && | ||
| data.node.argument.test.callee.property.name === 'isArray') || |
There was a problem hiding this comment.
Are you sure that we don't need the sx prop name check in this rule as well? 🤔
I suspect that given the existing rule, it would skip the following prop as well, even though it probably shouldn't. 🤔
xyz={[
...(Array.isArray(xyz) ? xs : [xyz]),
...(Array.isArray(slotProps?.layout?.xyz) ? slotProps.layout.xyz : [slotProps.layout.sxxyz),There was a problem hiding this comment.
This codemod only targets sx prop, so it will not look into this xyz prop.
There was a problem hiding this comment.
Oh, I saw sx checks in the || else rules and assumed these are the only checks. 🙈
LGTM then, sorry for the distraction. 👍
LukasTy
approved these changes
Aug 14, 2024
Comment on lines
+343
to
+346
| (data.node.argument.test.type === 'CallExpression' && | ||
| data.node.argument.test.callee.type === 'MemberExpression' && | ||
| data.node.argument.test.callee.object.name === 'Array' && | ||
| data.node.argument.test.callee.property.name === 'isArray') || |
There was a problem hiding this comment.
Oh, I saw sx checks in the || else rules and assumed these are the only checks. 🙈
LGTM then, sorry for the distraction. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43230
The code above is a type of sx spread which works with MUI System. The codemod should not transform this code.
Unrelated to this PR but need to check if Pigment CSS will skip this code or not.