Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui][Popover] Fix description and title of hover interaction section #43290

Merged
merged 2 commits into from
Aug 15, 2024
Merged

[docs][material-ui][Popover] Fix description and title of hover interaction section #43290

merged 2 commits into from
Aug 15, 2024

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 14, 2024 •
edited
Loading

While reviewing issue #43231, I noticed that mouseover was incorrectly mentioned instead of mouseenter. I also updated the section title and renamed the file/demo.

Preview: https://deploy-preview-43290--material-ui.netlify.app/material-ui/react-popover/#mouse-hover-interaction

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: Popover The React component. package: material-ui Specific to @mui/material labels Aug 14, 2024
@mui-bot
Copy link

mui-bot commented Aug 14, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 558357d

@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Aug 14, 2024
Closed
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 14, 2024 04:30
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui][Popover] Fix description and section title of hover interaction section [docs][material-ui][Popover] Fix description and title of hover interaction section Aug 14, 2024
aarongarciah
aarongarciah reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Not related to this PR: this demo is unaccessible (the popover can't be reached). We should update it once we refactor the Popover component to use Base UI in the future.

@aarongarciah aarongarciah removed the request for review from DiegoAndai August 15, 2024 10:11
@ZeeshanTamboli ZeeshanTamboli merged commit 5fefa49 into mui:next Aug 15, 2024
22 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the docs-popover-fix-hover-demo-description branch August 15, 2024 10:38
This was referenced Aug 15, 2024
Merged
Merged
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Aug 15, 2024
Closed
@Janpot
Copy link
Member

Janpot commented Aug 15, 2024

There was a build skipped for this PR that broke on master.

I'm fixing in #43315

@ZeeshanTamboli
Copy link
Member Author

There was a build skipped for this PR that broke on master.

I'm fixing in #43315

Thanks, but already being taken care in #43316 separately.

@Janpot Janpot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarciah aarongarciah aarongarciah approved these changes

Assignees
No one assigned
Labels
component: Popover The React component. docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeeshanTamboli @mui-bot @Janpot @aarongarciah