[IconButton] Fix hover background color behavior #43271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43271--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
approved these changes
Aug 12, 2024
sai6855
added a commit
to sai6855/material-ui
that referenced
this pull request
Sep 11, 2024
This reverts commit d9d0a37.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hover behavior was broken on the IconButton component, as the styles are looking for
disabledRipple: false(for e.g. check this), while there was no default value set in the component.Preview: https://deploy-preview-43271--material-ui.netlify.app/material-ui/react-button/#icon-button
Previous behavior: https://next.mui.com/material-ui/react-button/#icon-button