Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Upgrade babel runtime #43243

Merged
merged 8 commits into from
Aug 27, 2024
Merged

[core] Upgrade babel runtime #43243

merged 8 commits into from
Aug 27, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 9, 2024

Was looking through our bundles to debug another issue, and noticed we were compiling in the interopRequireWildcard runtime helper instead of referencing it from @babel/runtime. This upgrades the expected @babel/runtime version to the one we depend on so that babel is up to date about which helpers are available and can use more of them.

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Aug 9, 2024
@mui-bot
Copy link

mui-bot commented Aug 9, 2024

Netlify deploy preview

https://deploy-preview-43243--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 01d6882

babel.config.js Outdated Show resolved Hide resolved
Janpot and others added 2 commits August 14, 2024 13:43
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot marked this pull request as ready for review August 15, 2024 20:23
@Janpot Janpot requested a review from a team August 15, 2024 20:24
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a setting to force using the installed version somehow? 🤔
My fear is that we sync it now, but after dependency bumping it will once again get out of sync. 🙈

@Janpot
Copy link
Member Author

Janpot commented Aug 16, 2024

Is there a setting to force using the installed version somehow?

I see two ways:

  • We could read it from package.json in the build script, and then pass it to babel config in an environment variable.
  • Or, we use a pnpm catalog to define a @babel/runtime version in the top-level package.json and read it from there directly in babel config.

I don't think it's a huge problem if it goes out of sync though, the package will be backwards compatible within the same major.

@Janpot
Copy link
Member Author

Janpot commented Aug 27, 2024

Looking into this separately. I found a package that is missing @babel/runtime as a dependency. Will add a check for that as well.

@Janpot Janpot merged commit 4fe4d8c into mui:master Aug 27, 2024
19 checks passed
@Janpot Janpot deleted the babel-runtime branch August 27, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants