[material-ui][Divider] Add aria-orientation #43241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
breaking change
component: divider
Netlify deploy preview
Bundle size reportDetails of bundle changes (Toolpad) |
aarongarciah
changed the title
aarongarciah
force-pushed
the
divider-vertical-a11y
branch
from
433ec05
to
cde7379
Compare
aarongarciah
changed the title
aarongarciah
commented
Aug 9, 2024
docs/data/material/components/dividers/VerticalDividerMiddle.js
Outdated
Show resolved
Hide resolved
aarongarciah
commented
Aug 9, 2024
There was a problem hiding this comment.
I took the opportunity to improve related tests by using semantic queries whenever possible.
|
@DiegoAndai I'll add a section in the v6 upgrade guide if we agree on it being a breaking change. |
👍🏼 let's do it |
siriwatknp
reviewed
Aug 13, 2024
docs/data/material/components/dividers/VerticalDividerMiddle.js
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Aug 13, 2024
There was a problem hiding this comment.
One final request for this is to add a note to https://mui.com/material-ui/react-divider/#orientation that the underlying DOM changes to div to follow the accessibility guideline.
|
@siriwatknp I added a note as you suggested: 
|
|
@DiegoAndai I added an entry in the v6 upgrade guide. This is now ready for a final review. |
siriwatknp
reviewed
Aug 13, 2024
docs/data/material/migration/migrating-to-v6/migrating-to-v6.md
Outdated
Show resolved
Hide resolved
DiegoAndai
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43275
Modifies the
Dividercomponent to render a<div role="separator" aria-orientation="vertical">instead of<hr>when using vertical orientation to adhere to the ARIA spec.This can be considered a breaking change since consumers might be targeting
hrelements for styling purposes.Benchmarks