Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use fs instead of fs-extra in script utils #43234

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

DiegoAndai
Copy link
Member

Use fs instead of fs-extra in utils to avoid this pitfall. I'm not sure why it didn't fail in #43190 but it did in #43233.

@DiegoAndai DiegoAndai added the core Infrastructure work going on behind the scenes label Aug 8, 2024
@DiegoAndai DiegoAndai requested a review from Janpot August 8, 2024 15:24
@DiegoAndai DiegoAndai self-assigned this Aug 8, 2024
@mui-bot
Copy link

mui-bot commented Aug 8, 2024

Netlify deploy preview

https://deploy-preview-43234--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e57388e

scripts/utils.mjs Outdated Show resolved Hide resolved
@DiegoAndai DiegoAndai merged commit 34add58 into mui:next Aug 9, 2024
19 checks passed
@DiegoAndai DiegoAndai deleted the fix-script-utils-import branch August 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants