Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update showcase to include Toolpad Core #43226

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

bharatkashyap
Copy link
Member

  • Update the Products switcher copy for Toolpad

    • "Toolpad Studio" -> "Toolpad"
    • "Self-hosted, low-code builder.." -> "Components and tools for building dashboards and internal apps"
    • "Start using Toolpad" -> "Start using Toolpad Core/Studio"
    • "Learn more about why to use Toolpad" -> "Learn more about Toolpad Core/Studio"
  • Update the demo tabs

    • Add the <DashboardLayout /> as the demo for "Core"

    • Merge the earlier demo tabs into one for "Studio"

      "Use a drag-and-drop interface to build your app's configuration. Changes made in Studio are automatically synced to .yml files, and vice-versa. Bring your own components and data."

      as a single description

Screenshot 2024-08-08 at 3 38 43 PM

@bharatkashyap bharatkashyap added the website Pages that are not documentation-related, marketing-focused. label Aug 8, 2024
@mui-bot
Copy link

mui-bot commented Aug 8, 2024

Netlify deploy preview

https://deploy-preview-43226--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7a5f6fc

@prakhargupta1
Copy link
Member

The Beta chip seems off. Everything else looks good to me!

Screenshot 2024-08-09 at 11 56 47 AM

@bharatkashyap
Copy link
Member Author

bharatkashyap commented Aug 9, 2024

The Beta chip seems off. Everything else looks good to me!

That isn't from a change in this PR, that one is already merged in #42952

We can fix that separately I think - an item to add in the grooming next week?

@Janpot
Copy link
Member

Janpot commented Aug 13, 2024

I think we can make the code preview more to the point. It doesn't have to be the exact same as what we render. e.g. look at the the MUI X code preview. I think we can also leave out the explanation text that we add for Studio. The code can speak for itself.

We can inline and reduce the amount of navigation and leave out the other props and children, what do you think of just the following as a preview?

<AppProvider navigation={[
  {
    kind: 'header',
    title: 'Main items',
  },
  {
    segment: 'dashboard',
    title: 'Dashboard',
    icon: <DashboardIcon />,
  }
  // ...
]}>
  <DashboardLayout>
    <PageContainer>
      {/* ... */}
    </PageContainer>
  </DashboardLayout>
</AppProvider>

@bharatkashyap
Copy link
Member Author

I think we can make the code preview more to the point. It doesn't have to be the exact same as what we render. e.g. look at the the MUI X code preview. I think we can also leave out the explanation text that we add for Studio. The code can speak for itself.

We can inline and reduce the amount of navigation and leave out the other props and children, what do you think of just the following as a preview?

<AppProvider navigation={[
  {
    kind: 'header',
    title: 'Main items',
  },
  {
    segment: 'dashboard',
    title: 'Dashboard',
    icon: <DashboardIcon />,
  }
  // ...
]}>
  <DashboardLayout>
    <PageContainer>
      {/* ... */}
    </PageContainer>
  </DashboardLayout>
</AppProvider>

Agree with shortening the preview code. About the Studio description, I would keep at least one sentence talking about Studio being a drag and drop builder given there isn't any context around it anywhere else on the landing page.

@Janpot
Copy link
Member

Janpot commented Aug 13, 2024

About the Studio description, I would keep at least one sentence talking about Studio being a drag and drop builder given there isn't any context around it anywhere else on the landing page.

Yes, we can keep the studio one, I meant we can remove it for the core tab. Sorry, I wasn't very clear there 😄

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bharatkashyap bharatkashyap enabled auto-merge (squash) August 13, 2024 13:01
@Janpot
Copy link
Member

Janpot commented Aug 13, 2024

@bharatkashyap Can you look into this scroll issue?

Screen.Recording.2024-08-13.at.15.14.09.mov

@bharatkashyap
Copy link
Member Author

bharatkashyap commented Aug 15, 2024

Screen.Recording.2024-08-15.at.1.39.49.PM.mov

@prakhargupta1 @Janpot Updated with a fix for the reported scroll issue, is this good to merge now?

@bharatkashyap bharatkashyap merged commit d551dd5 into mui:next Aug 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants