Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove react-router package from pigment-css-vite-app #43201

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 6, 2024

This package isn't used and needed in pigment-css-vite-app. Only react-router-dom is needed.

Closes #43172

@ZeeshanTamboli ZeeshanTamboli added the core Infrastructure work going on behind the scenes label Aug 6, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Remove react-router from pigment-css-vite-app [core] Remove react-router package from pigment-css-vite-app Aug 6, 2024
@mui-bot
Copy link

mui-bot commented Aug 6, 2024

Netlify deploy preview

https://deploy-preview-43201--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1449d66

@ZeeshanTamboli ZeeshanTamboli requested a review from a team August 6, 2024 10:10
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 6, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 6, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 2450751 into mui:next Aug 6, 2024
19 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-react-router-package-from-pigment-css-vite-app branch August 6, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants