Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove unnecessary types packages from @mui/internal-babel-macros #43193

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 6, 2024

Found during the review of #43160. Initially added in #40262.

@ZeeshanTamboli ZeeshanTamboli added the core Infrastructure work going on behind the scenes label Aug 6, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Remove unnecessary types packages from mui-babel-maros [core] Remove unnecessary types packages from mui-babel-macros Aug 6, 2024
@mui-bot
Copy link

mui-bot commented Aug 6, 2024

Netlify deploy preview

https://deploy-preview-43193--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e7157fa

@ZeeshanTamboli ZeeshanTamboli changed the title [core] Remove unnecessary types packages from mui-babel-macros [core] Remove unnecessary types packages from @mui/internal-babel-macros Aug 6, 2024
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 6, 2024 05:38
@ZeeshanTamboli ZeeshanTamboli requested a review from a team August 6, 2024 05:47
@michaldudak
Copy link
Member

Nice catch!

@ZeeshanTamboli ZeeshanTamboli merged commit 41a72bd into mui:next Aug 6, 2024
19 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-unnecessary-types-packages-from-babel-macros branch August 6, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants