[material-ui] Make tests compatible with React 19 #43155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
package: material-ui
Netlify deploy previewhttps://deploy-preview-43155--material-ui.netlify.app/ Bundle size report |
DiegoAndai
commented
Aug 2, 2024
Comment on lines
3006
to
3009
| const expectedCallHistory = | ||
| reactMajor === 19 ? [null, 'one', 'one', 'four'] : [null, 'one', 'four']; | ||
|
|
||
| expect(handleHighlightChange).to.deep.equal(expectedCallHistory); |
There was a problem hiding this comment.
I'm not sure why this one (or the similar one for joy) happened, might be something related to the Strict mode changes, but the explanation on the upgrade guide is not very detailed.
DiegoAndai
requested review from
mnajdova,
michaldudak and
aarongarciah
and removed request for
mnajdova and
michaldudak
aarongarciah
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Looks good! I left some comments, most of them directed at making tests a bit more future-proof by checking for reactMajor >= 19 instead of reactMajor === 19 so we don't need to modify tests once React 20 is out (if no specific changes affect the tests, of course).
|
@aarongarciah I implemented the future-proofing changes for future React versions, and replied to the other questions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #42824
Adapt to React 19 in our tests. Most of the changes are explained by either:
For the ones that are not explained by these changes, I left comments on.
These commits were cherry-picked from #42824.