[core] Apply top-level eslint rule to docs and fix violations #43126
Conversation
Netlify deploy previewhttps://deploy-preview-43126--material-ui.netlify.app/ Bundle size report |
| @@ -41,27 +41,9 @@ export type InternalStandardProps< | |||
| style?: React.CSSProperties; | |||
| }; | |||
|
|
|||
| export type PaletteMode = 'light' | 'dark'; | |||
There was a problem hiding this comment.
This file has a
export * from './styles';So moving it there shouldn't affect public API
github-actions
bot
added
the
PR: out-of-date
| @@ -13,6 +13,32 @@ const forbidCreateStylesMessage = | |||
|
|
|||
| const ENABLE_REACT_COMPILER_PLUGIN = false; | |||
|
|
|||
| const NO_RESTRICTED_IMPORTS_PATHS_TOP_LEVEL_PACKAGES = [ | |||
There was a problem hiding this comment.
We should include @mui/system as well
There was a problem hiding this comment.
That generates 486 new eslint warnings. Are you sure we intend to discourage top-level imports from this package? This PR essentially fixes the initial rule to apply to the docs again, which appeared to have been accidentally broken.
If we want to introduce the same behavior for @mui/system, perhaps it makes sense to do it separately? it's potentially also a task the community could take on?
There was a problem hiding this comment.
Makes sense, I didn't know it would introduce that many warnings 😅
github-actions
bot
removed
the
PR: out-of-date
Following up on #43108 (review)
Also moving
PaletteModeandColorto@mui/material/styles