Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utils] Fix issues reported by the React Compiler #43051

Merged
merged 5 commits into from
Jul 25, 2024
Merged

[utils] Fix issues reported by the React Compiler #43051

merged 5 commits into from
Jul 25, 2024

Conversation

markliu2013
Copy link
Contributor

@markliu2013 markliu2013 commented Jul 24, 2024 •
edited
Loading

Part of #42564

@mui-bot
Copy link

mui-bot commented Jul 24, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43051--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 37575f0

@zannager zannager added the package: utils Specific to the @mui/utils package label Jul 24, 2024
aarongarciah
aarongarciah reviewed Jul 25, 2024
View reviewed changes
packages/mui-utils/src/useControlled/useControlled.js Outdated Show resolved Hide resolved
packages/mui-utils/src/useForkRef/useForkRef.ts Outdated Show resolved Hide resolved
packages/mui-utils/src/useId/useId.ts Outdated Show resolved Hide resolved
packages/mui-utils/src/useOnMount/useOnMount.ts Outdated Show resolved Hide resolved
@markliu2013
Copy link
Contributor Author

@aarongarciah , is it ok to merge now?

markliu2013 and others added 5 commits July 25, 2024 18:07
@markliu2013 @aarongarciah
fixed react compiler issues for mui-utils
be47973
@markliu2013 @aarongarciah
Update packages/mui-utils/src/useControlled/useControlled.js
3d7c683 
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com>
Signed-off-by: Mark <markliu2013@gmail.com>
@markliu2013 @aarongarciah
Update packages/mui-utils/src/useForkRef/useForkRef.ts
557e288 
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com>
Signed-off-by: Mark <markliu2013@gmail.com>
@markliu2013 @aarongarciah
Update packages/mui-utils/src/useId/useId.ts
dfb2c17 
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com>
Signed-off-by: Mark <markliu2013@gmail.com>
@markliu2013 @aarongarciah
Update packages/mui-utils/src/useOnMount/useOnMount.ts
37575f0 
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com>
Signed-off-by: Mark <markliu2013@gmail.com>
@aarongarciah aarongarciah mentioned this pull request Jul 25, 2024
Open
66 tasks
@aarongarciah
Copy link
Member

Thanks @markliu2013!

@aarongarciah aarongarciah enabled auto-merge (squash) July 25, 2024 16:20
@aarongarciah aarongarciah merged commit 263dbdd into mui:next Jul 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarciah aarongarciah aarongarciah approved these changes

Assignees
No one assigned
Labels
package: utils Specific to the @mui/utils package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markliu2013 @mui-bot @aarongarciah @zannager