[system] Make createBreakpoints independent for stringify theme
#43048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: system
Netlify deploy previewhttps://deploy-preview-43048--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
force-pushed
the
fix/stringify
branch
from
c93fbb8
to
ace922b
Compare
siriwatknp
changed the title
createBreakpoints independent for stringify themecreateBreakpoints independent for stringify theme
brijeshb42
reviewed
Jul 24, 2024
| @@ -50,7 +50,7 @@ export { default as createStyled } from './createStyled'; | |||
| export * from './createStyled'; | |||
| export { default as styled } from './styled'; | |||
| export { default as createTheme } from './createTheme'; | |||
| export { default as createBreakpoints } from './createTheme/createBreakpoints'; | |||
| export { default as createBreakpoints } from './createBreakpoints/createBreakpoints'; | |||
There was a problem hiding this comment.
Do we want this in the top level export? I'd say let's keep it at path level.
There was a problem hiding this comment.
I think we need to keep it like this otherwise it's a breaking change which is out of scope of this PR.
brijeshb42
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Emotion is still bundled even though it is not used. The image below is a Next.js app with bundle analyzer:
Thanks to @brijeshb42, he found out that the root cause comes from the import in the stringifyTheme:
Solution
Moved
createBreakpointsinto its own folder (in system) and reexport it asunstable_createBreakpointsbecause we just need it for internal integration.Result:
Bye Emotion.