Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Make DemoSandbox agnostic of productId #43042

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[docs] Make DemoSandbox agnostic of productId #43042

merged 1 commit into from
Jul 24, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 23, 2024 •
edited
Loading

Add usesCssVarsTheme to replace productId to avoid the hack in mui/mui-toolpad#3830

@Janpot Janpot added the docs Improvements or additions to the documentation label Jul 23, 2024
@Janpot Janpot changed the title [docs] Add usesCssVarsTheme to DemoSandbox [docs] Make DemoSandbox polymorph wrt productId Jul 23, 2024
@mui-bot
Copy link

mui-bot commented Jul 23, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43042--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against db559c1

@Janpot Janpot mentioned this pull request Jul 23, 2024
Merged
@Janpot Janpot changed the title [docs] Make DemoSandbox polymorph wrt productId [docs] Make DemoSandbox agnostic wrt productId Jul 23, 2024
@Janpot Janpot changed the title [docs] Make DemoSandbox agnostic wrt productId [docs] Make DemoSandbox agnostic of productId Jul 23, 2024
@Janpot Janpot changed the title [docs] Make DemoSandbox agnostic of productId [docs] Make DemoSandbox agnostic of productId Jul 23, 2024
@Janpot Janpot marked this pull request as ready for review July 23, 2024 14:27
@Janpot Janpot requested a review from a team July 23, 2024 14:27
@Janpot Janpot merged commit e6d9c3f into mui:next Jul 24, 2024
19 of 20 checks passed
@Janpot Janpot deleted the cssVars branch July 24, 2024 10:29
@mui mui deleted a comment from X1x1x2 Jul 24, 2024
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@Janpot @joserodolfofreitas
[docs] Make DemoSandbox agnostic of productId (mui#43042)
f892b4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @alexfauquette