[docs] Polish migration guide #43021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
439
to
442
| ```diff | ||
| - import { styled } from '@mui/material/styles'; | ||
| + import { styled } from '@mui/material-pigment-css'; | ||
| -import { styled } from '@mui/material/styles'; | ||
| +import { styled } from '@mui/material-pigment-css'; | ||
| ``` |
There was a problem hiding this comment.
I'm confused about this new package, I don't understand the direction. I think we need to move to a place where @mui/material is only exporting one thing: CSS, and developers can opt-in to copy the source if they want. We won't be able to get this by having material-ui specific packages. If we really need a separate package (I don't understand the breaking change argument because Pigment CSS is unstable, an intermediary package around it won't change it), I think we should use MUI System for it.
So can we not do this but move towards?
-import { styled } from '@mui/material/styles';
+import { styled } from '@pigment-css/react';same for the other modules
-import { useTheme } from '@mui/material/styles';
+import { useTheme } from '@pigment-css/react';
oliviertassinari
force-pushed
the
polish-migration-guide
branch
from
5f1435a
to
2fb70c6
Compare
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
polish-migration-guide
branch
from
2fb70c6
to
c0a4db2
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small content formating issues I could spot on the page.