Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add pigment and base ui scopes to envinfo #43002

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 19, 2024

See #41942 (comment). This will help support ticket for Base UI, Pigment CSS and downstream dependents.

Aside: Any reason why @base_ui scope is with an underscore? Feels a bit unusual for npm package naming and different to what we've been doing before with no obvious benefit. I personally find it to work particularly badly with underlines in urls (github, npm, docs,...)

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jul 19, 2024
@mui-bot
Copy link

mui-bot commented Jul 19, 2024

Netlify deploy preview

https://deploy-preview-43002--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5777e63

@oliviertassinari oliviertassinari added the scope: infra Org infrastructure work going on behind the scenes label Jul 19, 2024
@oliviertassinari oliviertassinari changed the title [core] add pigment and base ui scopes to envinfo [core] Add pigment and base ui scopes to envinfo Jul 19, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 19, 2024

Any reason why @base_ui scope is with an underscore?

@Janpot We couldn't get the organization name yet. Used by https://www.npmjs.com/~base-ui?activeTab=packages right now. We haven't heard form GitHub yet.

Marija had a contact at GitHub who told us:

If they have a trademark for the name they will be able to get a much faster response and higher likelihood of a positive outcome. They can fill out our trademark form to start the process.

@colmtuite If a trademark application cost $250 and it means that we won't need to change npm package name down the line. This seems like a no brainer. Now, we need a final logo to do this.

@Janpot Janpot marked this pull request as ready for review July 19, 2024 22:02
@Janpot Janpot merged commit d3d1675 into mui:next Jul 22, 2024
20 of 21 checks passed
@colmtuite
Copy link
Contributor

@oliviertassinari I'll send a logo internally today so we can begin a trademark process.

@Janpot Janpot deleted the envinfo branch July 22, 2024 14:11
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 22, 2024

trademark process

A new task to track/coordinate this: https://www.notion.so/mui-org/label-Trademark-Base-UI-88f653d8a8b64cac96fa7546638ecc3d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants