-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Support code tabs overflow #42913
Conversation
Netlify deploy previewhttps://deploy-preview-42913--material-ui.netlify.app/ Bundle size report |
The build has 2 issues:
10:53:25 AM: ./pages/experiments/docs/DemoMultiTabs.js
10:53:25 AM: Attempted import error: 'COUNTRY_ISO_OPTIONS_SORTED' is not exported from '@mui/x-data-grid-generator' (imported as 'COUNTRY_ISO_OPTIONS_SORTED').
10:53:25 AM: ./pages/experiments/docs/DemoMultiTabs.js
10:53:25 AM: Attempted import error: 'STATUS_OPTIONS' is not exported from '@mui/x-data-grid-generator' (imported as 'STATUS_OPTIONS').
10:53:25 AM: ./pages/experiments/docs/DemoMultiTabs.js
10:53:25 AM: Attempted import error: 'INCOTERM_OPTIONS' is not exported from '@mui/x-data-grid-generator' (imported as 'INCOTERM_OPTIONS').
10:53:25 AM: ./pages/experiments/docs/renderers/country.js
10:53:25 AM: Attempted import error: 'COUNTRY_ISO_OPTIONS' is not exported from '@mui/x-data-grid-generator' (imported as 'COUNTRY_ISO_OPTIONS').
10:53:25 AM: ./pages/experiments/docs/renderers/incoterm.js
10:53:25 AM: Attempted import error: 'INCOTERM_OPTIONS' is not exported from '@mui/x-data-grid-generator' (imported as 'INCOTERM_OPTIONS').
10:53:25 AM: ./pages/experiments/docs/renderers/status.js
10:53:25 AM: Attempted import error: 'STATUS_OPTIONS' is not exported from '@mui/x-data-grid-generator' (imported as 'STATUS_OPTIONS').
The docs structure is the following one.
But the experiments is slightly different, because every think is directly in the For now the workaround was to import JSON files. You could probably create a
|
Updated. @alexfauquette, I have moved the renderers as you have suggested. In the experiments demo the filenames are a bit long now, but in the actual docs for xGrid this should not be the problem as we can keep the renderers in the subfolder |
Yes, and it would be a nice feature to only keep the file name without its folder to be able to import from anywhere without having to care about the UI impact |
Good shout @alexfauquette and @arminmeh - I'll add this to #41754 which I'm working on |
Thanks @bharatkashyap. Nice list of improvements in #41754 👍 I will merge this one then, so that we can update the grid docs. |
Please go ahead (only if it's not squeezing your existing bandwidth 😅) |
Related to mui/mui-x#9270
With a lot of files, tab names get squashed together.
Preview: https://deploy-preview-42913--material-ui.netlify.app/experiments/docs/demos/#multiple-tabs-demo