[material] Remove dependency to @mui/base #42907

mnajdova · 2024-07-11T09:35:03Z

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2024-07-11T10:00:38Z

Netlify deploy preview

https://deploy-preview-42907--material-ui.netlify.app/

@material-ui/utils: parsed: +152.12% , gzip: +70.16%
@material-ui/lab: parsed: +4.00% , gzip: +4.80%
@mui/joy: parsed: +0.20% , gzip: +0.24%
@mui/joy/Tooltip: parsed: +1.00% , gzip: +0.87%
@mui/joy/Autocomplete: parsed: +0.59% , gzip: +0.55%
@mui/joy/Select: parsed: +0.77% , gzip: +0.61%
@material-ui/unstyled: parsed: +0.65% , gzip: +0.09%
SpeedDialAction: parsed: -0.18% 😍, gzip: -0.31% 😍
@material-ui/core: parsed: -0.02% 😍, gzip: -0.08% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against cc5aea6

aarongarciah · 2024-07-11T13:41:38Z

@mnajdova today I merged #37301, which contains changes in mui-base. Can you update this PR to include them?

mnajdova · 2024-07-11T14:28:32Z

@mnajdova today I merged #37301, which contains changes in mui-base. Can you update this PR to include them?

Thanks for the heads up! I will update it tomorrow and have this ready for review :)

aarongarciah

Looks good

docs/pages/material-ui/api/popper.json

mnajdova · 2024-07-12T10:59:36Z

packages/api-docs-builder-core/baseUi/projectSettings.ts

@@ -27,6 +27,9 @@ export const projectSettings: ProjectSettings = {
  getHookInfo: getBaseUiHookInfo,
  translationLanguages: LANGUAGES,
  skipComponent: () => false,
+  skipHook: (filename) => {
+    return filename.match(/(useSlotProps)/) !== null;


This hook was anyway not documented, so I've added this option to skip, otherwise the docgen generation failed. It's an optional prop it won't break other ts projects.

mnajdova · 2024-07-12T11:02:02Z

@aarongarciah this is ready for final review. Changes after the approval:

moved the utils used in MUI X to @mui/utils to avoid having to add @mui/material as a dependency to some packages that are Material UI agnostic (charts for example)
fixed the docs generation script, as Base UI is not just re-exporting some hooks from @mui/utils (useSlotProps)

aarongarciah

🏎️ 🚀

mnajdova · 2024-07-12T11:31:50Z

Thanks for the review @aarongarciah. Next steps:

cherry-pick on master
create PR on MUI X with the updates
after we ensure everything works, mark the @mui/base package as private and stop releasing it

I will move with the next steps.

oliviertassinari

What's the motivation for this change? It seems that the PR description is missing context.

oliviertassinari · 2024-07-12T22:09:01Z

docs/data/material/pagesApi.js

@@ -27,6 +27,7 @@ module.exports = [
  { pathname: '/material-ui/api/checkbox' },
  { pathname: '/material-ui/api/chip' },
  { pathname: '/material-ui/api/circular-progress' },
+  { pathname: '/material-ui/api/click-away-listener' },


I'm confused about this. Would it mean we will have:

@mui/material/ClickAwayListener

@mui/base/ClickAwayListener

@base_ui/react/ClickAwayListener. I mean, I imagine we need it https://stackoverflow.com/questions/32553158/detect-click-outside-react-component

oliviertassinari · 2024-07-12T22:09:55Z

docs/data/material/pagesApi.js

@@ -125,6 +128,7 @@ module.exports = [
  { pathname: '/material-ui/api/tab-panel' },
  { pathname: '/material-ui/api/tabs' },
  { pathname: '/material-ui/api/tab-scroll-button' },
+  { pathname: '/material-ui/api/textarea-autosize' },


Same idea as above with https://stackoverflow.com/questions/454202/creating-a-textarea-with-auto-resize

oliviertassinari · 2024-07-21T23:25:33Z

From the exposure to this change and dive discussed in mui/mui-x#13823 can we revert this PR and go in the opposite direction?

I also got confused in #42604 (comment), we shouldn't have 3 versions at any point in time. As a side note, we need the git history of those components, it's missing after this PR.

It seems that having those modules in @mui/base, hosted in http://github.com/mui/material-ui would already to be a clear step forward, with no real downsides.
Now, I'm truly advocating to have those hosted in http://github.com/mui/base-ui and exposed from @base_ui/react as unstable/legacy.

mnajdova · 2024-07-22T12:06:29Z

From the exposure to this change and dive discussed in mui/mui-x#13823 can we revert this PR and go in the opposite direction?

What exactly is the opposite direction?

I also got confused in #42604 (comment), we shouldn't have 3 versions at any point in time.

Right, I would assume by moving the component to Mateiral UI, we won't need to do any updates on @mui/base, the initial plan is to no longer release this package, mark it as private, and eventually remove the code once we have @base_ui.

It seems that having those modules in @mui/base, hosted in http://github.com/mui/material-ui would already to be a clear step forward, with no real downsides.

The motivation for the change is that we will no longer need to make updates on @mui/base, not about where the components are being documented.

Now, I'm truly advocating to have those hosted in http://github.com/mui/base-ui and exposed from @base_ui/react as unstable/legacy.

I am not sure which if any of these components will live in Base UI, and what would be the form of these. What is the value of adding legacy stuff in Base UI, if these are only used in Material UI and Base UI do not plan to support these or plans to change the API around them. I will let @colmtuite and @michaldudak answer on this, but in my opinion this was not an option, hence I went with moving them to Material UI.

mnajdova · 2024-07-22T13:32:43Z

As a side note, we need the git history of those components, it's missing after this PR.

I can fix this in #43028, I've applied the changes needed for the NoSsr, but I will wait with updating all components until we have a decision on how to move forward.

colmtuite · 2024-07-22T14:17:39Z

I would assume by moving the component to Mateiral UI, we won't need to do any updates on @mui/base, the initial plan is to no longer release this package, mark it as private, and eventually remove the code once we have @base_ui.

This makes sense to me, and is what the majority of the team have been planning for at least the past few months. I figure we would just take each util/package, figure out the most appropriate place for it to belong, and move it there. Then that team are responsible for it. Sometimes, the most appropriate place will be Base UI, sometimes, Material UI, sometimes X, and potentially sometimes a shared utils lib.

But corrupting the new Base UI lib by prematurely abstracting legacy utils/components to it—when we don't know if they belong there long-term—is the worst path we could take. It's much worse than duplicating things in multiple locations.

mnajdova added 9 commits July 11, 2024 10:16

Move @mui/base/utils

d8c5595

move composeClasses

44b6dc7

Move Autocomplete & Badge dependencies

2224463

Move NoSsr

dadb6ea

Move Slider and ClassNameGenerator

bdb3601

Move ClickAwayListener and Modal dependencies

2e71c28

move Popper, FocusTrap

09efcda

Move rest of the dependencies and remove @mui/base from package.json

b7a6ecb

prettier

f99cec3

mnajdova added the core Infrastructure work going on behind the scenes label Jul 11, 2024

mnajdova added 3 commits July 11, 2024 11:42

pnpm install

eaad5a2

fixes

f87da15

pnpm dedupe

f862f49

mnajdova added 7 commits July 11, 2024 12:26

fix popper

eb71306

more fixes

5ce9e53

docs:api

0c6c4a9

lint issues

a0d474f

more fixes

468335a

more fixes

4913bbe

fix tests

41cc450

mnajdova marked this pull request as ready for review July 11, 2024 12:01

DiegoAndai mentioned this pull request Jul 11, 2024

[release] v5.16.1 #42897

Merged

DiegoAndai mentioned this pull request Jul 11, 2024

[release] v6.0.0-beta.0 #42898

Merged

zannager requested a review from michaldudak July 11, 2024 16:49

mnajdova added 2 commits July 12, 2024 08:58

Merge branch 'next' into core/remove-base-ui-dependency

ba47077

apply changes from latest next

107a86e

mnajdova added the needs cherry-pick The PR should be cherry-picked to master after merge label Jul 12, 2024

mnajdova requested review from aarongarciah and removed request for michaldudak July 12, 2024 07:26

export utils used in MUI X

16ef35b

aarongarciah approved these changes Jul 12, 2024

View reviewed changes

docs/pages/material-ui/api/popper.json Show resolved Hide resolved

mnajdova added 3 commits July 12, 2024 12:15

move utils to @mui/utils

fd3dcad

prettier

e3cf68d

fix CI

cc5aea6

mnajdova commented Jul 12, 2024

View reviewed changes

aarongarciah approved these changes Jul 12, 2024

View reviewed changes

mnajdova merged commit 3bbff37 into mui:next Jul 12, 2024
23 checks passed

github-actions bot pushed a commit that referenced this pull request Jul 12, 2024

[material] Remove dependency to @mui/base (#42907)

5cb5b4c

github-actions bot mentioned this pull request Jul 12, 2024

[material] Remove dependency to @mui/base (@mnajdova) #42917

Merged

oliviertassinari reviewed Jul 12, 2024

View reviewed changes

ZeeshanTamboli mentioned this pull request Jul 14, 2024

[material-ui][Autocomplete] Fix listbox opens and closes on click when used with limitTags #42494

Open

This was referenced Jul 21, 2024

Type erros in @mui/utils #43020

Closed

[material] Add missing dependency #42961

Merged

joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024

[material] Remove dependency to @mui/base (mui#42907)

859b35a

ZeeshanTamboli mentioned this pull request Aug 23, 2024

[material-ui][Unstable_TrapFocus] Fix getTabbable function return type #42237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[material] Remove dependency to @mui/base #42907

[material] Remove dependency to @mui/base #42907

mnajdova commented Jul 11, 2024

mui-bot commented Jul 11, 2024 •

edited

Loading

aarongarciah commented Jul 11, 2024

mnajdova commented Jul 11, 2024

aarongarciah left a comment

mnajdova Jul 12, 2024

mnajdova commented Jul 12, 2024 •

edited

Loading

aarongarciah left a comment

mnajdova commented Jul 12, 2024

oliviertassinari left a comment

oliviertassinari Jul 12, 2024

oliviertassinari Jul 12, 2024

oliviertassinari commented Jul 21, 2024 •

edited

Loading

mnajdova commented Jul 22, 2024 •

edited

Loading

mnajdova commented Jul 22, 2024

colmtuite commented Jul 22, 2024

[material] Remove dependency to @mui/base #42907

[material] Remove dependency to @mui/base #42907

Conversation

mnajdova commented Jul 11, 2024

mui-bot commented Jul 11, 2024 • edited Loading

Netlify deploy preview

Bundle size report

aarongarciah commented Jul 11, 2024

mnajdova commented Jul 11, 2024

aarongarciah left a comment

Choose a reason for hiding this comment

mnajdova Jul 12, 2024

Choose a reason for hiding this comment

mnajdova commented Jul 12, 2024 • edited Loading

aarongarciah left a comment

Choose a reason for hiding this comment

mnajdova commented Jul 12, 2024

oliviertassinari left a comment

Choose a reason for hiding this comment

oliviertassinari Jul 12, 2024

Choose a reason for hiding this comment

oliviertassinari Jul 12, 2024

Choose a reason for hiding this comment

oliviertassinari commented Jul 21, 2024 • edited Loading

mnajdova commented Jul 22, 2024 • edited Loading

mnajdova commented Jul 22, 2024

colmtuite commented Jul 22, 2024

mui-bot commented Jul 11, 2024 •

edited

Loading

mnajdova commented Jul 12, 2024 •

edited

Loading

oliviertassinari commented Jul 21, 2024 •

edited

Loading

mnajdova commented Jul 22, 2024 •

edited

Loading