Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui] Add @emotion/react peer dependency to @mui/material-nextjs #42885

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[material-ui] Add @emotion/react peer dependency to @mui/material-nextjs #42885

merged 1 commit into from
Jul 16, 2024

Conversation

jeloagnasin
Copy link
Contributor

Resolves #42884

@mui-bot
Copy link

mui-bot commented Jul 8, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42885--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fd8c814

@aarongarciah aarongarciah self-requested a review July 8, 2024 06:09
@aarongarciah aarongarciah added dependencies Update of dependencies nextjs labels Jul 8, 2024
@aarongarciah aarongarciah requested review from siriwatknp and removed request for aarongarciah July 8, 2024 08:15
@aarongarciah aarongarciah mentioned this pull request Jul 8, 2024
Closed
@aarongarciah aarongarciah added the package: material-ui Specific to @mui/material label Jul 8, 2024
@aarongarciah aarongarciah changed the title [material-ui] add peer dependency to mui-material-nextjs [material-ui] Add @emotion/react peer dependency to mui-material-nextjs Jul 8, 2024
@aarongarciah aarongarciah changed the title [material-ui] Add @emotion/react peer dependency to mui-material-nextjs [material-ui] Add @emotion/react peer dependency to @mui/material-nextjs Jul 8, 2024
siriwatknp
siriwatknp approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change makes sense to me. 👍 Thanks for fixing this.

@siriwatknp siriwatknp merged commit e19fce6 into mui:next Jul 16, 2024
21 of 22 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@jeloagnasin @joserodolfofreitas
[material-ui-nextjs] Add @emotion/react as peer dependency (mui#42885)
cec5284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
dependencies Update of dependencies nextjs package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing peer dependency for mui-material-nextjs
4 participants
@jeloagnasin @mui-bot @siriwatknp @aarongarciah