[docs][LinearProgress] Fix buffer demo #42858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
added
docs
mbrookes
changed the title
Netlify deploy previewhttps://deploy-preview-42858--material-ui.netlify.app/ Bundle size report |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During this internal discussion I noticed that the LinearProgress buffer demo doesn't behave how one might expect (steady progress, erratic buffering), so this fixes that, and a couple of bugs where values can go out of range.
There's an argument (see above discussion) that it shouldn't be a progress indicator to begin with, and that the animated track is ugly and distracting, and no longer to spec, but those are separate issues altogether.
As it's just scratching an itch, I've added the "priority: low" label, but it shouldn't be more than five minutes of someone's time to review.
https://deploy-preview-42858--material-ui.netlify.app/material-ui/react-progress/#linear-buffer