-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][joy-ui] Remove warning from getInitColorSchemeScript
#42838
Conversation
Netlify deploy previewhttps://deploy-preview-42838--material-ui.netlify.app/ @material-ui/core: parsed: -0.05% 😍, gzip: -0.08% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
useColorScheme, | ||
getInitColorSchemeScript: deprecatedGetInitColorSchemeScript, | ||
} = createCssVarsProvider<SupportedColorScheme, typeof THEME_ID>({ | ||
const { CssVarsProvider, useColorScheme, getInitColorSchemeScript } = createCssVarsProvider< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the @deprecated
tag to getInitColorSchemeScript
to hint at it in IDEs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also suggested here: #42247 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
* + <InitColorSchemeScript />; | ||
* ``` | ||
*/ | ||
export const getInitColorSchemeScript = getInitColorSchemeScriptSystem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the ci.yml change?
This error https://github.com/mui/material-ui/actions/runs/9806956012/job/27079721815. Not related to this PR, the fix is to upgrade the version but I don't know the root cause. |
From #42829 (comment)
Updated the docs to fallback to
getInitColorSchemeScript
in v5 (MUI X needs this).