Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Cleanup @mui/docs usage and legacy re-exports #42833

Merged
merged 10 commits into from
Jul 3, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 3, 2024

@LukasTy LukasTy added core Infrastructure work going on behind the scenes scope: docs-infra Specific to the docs-infra product scope: code-infra Specific to the core-infra product labels Jul 3, 2024
@LukasTy LukasTy self-assigned this Jul 3, 2024
@mui-bot
Copy link

mui-bot commented Jul 3, 2024

Netlify deploy preview

https://deploy-preview-42833--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4583bc0

@LukasTy LukasTy marked this pull request as ready for review July 3, 2024 10:34
@LukasTy LukasTy requested review from a team July 3, 2024 10:35
@LukasTy
Copy link
Member Author

LukasTy commented Jul 3, 2024

@Janpot I've also removed HighlightedCode, Link, and MarkdownElement re-exports due to the changes in toolpad: mui/mui-toolpad#3751.
Requesting a re-review.
P.S. I've tried moving the HighlightedCode.test.js file to mui-docs package, but that introduced TS issues.
Do you think it's worth setting up testing on mui-docs or can that be left for a separate effort?

@LukasTy LukasTy requested a review from Janpot July 3, 2024 12:56
@Janpot
Copy link
Member

Janpot commented Jul 3, 2024

I've think I've ported some of the tests last time. aren't they running? i may have not verified this week enough

@LukasTy
Copy link
Member Author

LukasTy commented Jul 3, 2024

I've think I've ported some of the tests last time. aren't they running? i may have not verified this week enough

Well, there are no test dependencies in this package: https://github.com/mui/material-ui/blob/next/packages/mui-docs/package.json 🙈 🤔

@LukasTy LukasTy merged commit 9f8e4f5 into mui:next Jul 3, 2024
22 checks passed
@LukasTy LukasTy deleted the cleanup-docs-exports branch July 3, 2024 14:33
@Janpot
Copy link
Member

Janpot commented Jul 3, 2024

Ah, it was in an upcoming PR

@LukasTy
Copy link
Member Author

LukasTy commented Jul 3, 2024

Ah, it was in an upcoming PR

Sorry, I didn't see it. 🙈

joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants