Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Add batch of design polish #42823

Merged
merged 4 commits into from
Jul 2, 2024
Merged

[docs-infra] Add batch of design polish #42823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddd6422
polish copy, comment, and anchor link buttons
danilo-leal Jul 2, 2024
3a6f7ea
polish alignment on the codeblock tabs
danilo-leal Jul 2, 2024
6b467f9
fix the page tabs (expand width and add backdrop filter)
danilo-leal Jul 2, 2024
8bd947d
tune down colors from the thumbs up and down icons a bit
danilo-leal Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions docs/src/modules/components/AppLayoutDocsFooter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,16 +407,14 @@ export default function AppLayoutDocsFooter(props) {
<Tooltip title={t('feedbackYes')}>
<IconButton onClick={handleClickThumb(1)} aria-pressed={rating === 1}>
<ThumbUpAltRoundedIcon
color={rating === 1 ? 'primary' : undefined}
sx={{ fontSize: 15 }}
sx={{ fontSize: 15, color: rating === 1 ? 'primary' : 'text.secondary' }}
/>
</IconButton>
</Tooltip>
<Tooltip title={t('feedbackNo')}>
<IconButton onClick={handleClickThumb(0)} aria-pressed={rating === 0}>
<ThumbDownAltRoundedIcon
color={rating === 0 ? 'error' : undefined}
sx={{ fontSize: 15 }}
sx={{ fontSize: 15, color: rating === 0 ? 'error' : 'text.secondary' }}
/>
</IconButton>
</Tooltip>
Expand Down
14 changes: 9 additions & 5 deletions docs/src/modules/components/ComponentPageTabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from 'react';
import PropTypes from 'prop-types';
import { useRouter } from 'next/router';
import { styled } from '@mui/material/styles';
import { styled, alpha } from '@mui/material/styles';
import Box from '@mui/material/Box';
import { useTranslate } from 'docs/src/modules/utils/i18n';
import { Link } from '@mui/docs/Link';
Expand Down Expand Up @@ -98,12 +98,13 @@ export default function ComponentPageTabs(props) {
<Box
component="nav"
className="component-tabs"
sx={{
sx={(theme) => ({
width: '100%',
position: 'sticky',
top: 57, // to be positioned below the app bar
mt: 2,
mx: { xs: -2, sm: -1 },
backgroundColor: 'background.default',
backdropFilter: 'blur(8px)',
backgroundColor: 'rgba(255,255,255,0.8)',
borderBottom: 1,
borderColor: 'divider',
zIndex: 1000,
Expand All @@ -119,7 +120,10 @@ export default function ComponentPageTabs(props) {
height: '2px',
backgroundColor: 'primary.light',
},
}}
...theme.applyDarkStyles({
backgroundColor: alpha(theme.palette.primaryDark[900], 0.7),
}),
})}
>
{linkTabData.map((linkTab) => (
<LinkTab
Expand Down
4 changes: 2 additions & 2 deletions docs/src/modules/components/HighlightedCodeWithTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,11 +259,11 @@ export const CodeTab = styled(TabBase)<{ ownerState: { mounted: boolean; contain
],
...theme.unstable_sx({
height: 26,
p: '0 8px 2px 8px',
p: '2px 8px',
bgcolor: 'transparent',
lineHeight: 1.2,
outline: 'none',
minWidth: 52,
minWidth: 45,
cursor: 'pointer',
borderRadius: 99,
position: 'relative',
Expand Down
18 changes: 10 additions & 8 deletions packages/mui-docs/src/MarkdownElement/MarkdownElement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,16 @@ const Root = styled('div')(
marginLeft: 8,
height: 26,
width: 26,
backgroundColor: `var(--muidocs-palette-primary-50, ${lightTheme.palette.grey[50]})`,
color: `var(--muidocs-palette-grey-600, ${lightTheme.palette.grey[600]})`,
border: '1px solid',
borderColor: `var(--muidocs-palette-divider, ${lightTheme.palette.divider})`,
backgroundColor: 'transparent',
border: '1px solid transparent',
borderRadius: 8,
transition: theme.transitions.create(
['visibility', 'background-color', 'color', 'border-color'],
{
duration: theme.transitions.duration.shortest,
},
),
'&:hover': {
backgroundColor: alpha(lightTheme.palette.primary[100], 0.4),
borderColor: `var(--muidocs-palette-primary-100, ${lightTheme.palette.primary[100]})`,
Expand All @@ -218,7 +223,7 @@ const Root = styled('div')(
'& .comment-link': {
display: 'none', // So we can have the comment button opt-in.
marginLeft: 'auto',
transition: theme.transitions.create('opacity', {
transition: theme.transitions.create(['background-color', 'color', 'border-color'], {
duration: theme.transitions.duration.shortest,
}),
'& svg': {
Expand Down Expand Up @@ -547,7 +552,6 @@ const Root = styled('div')(
display: 'inline-flex',
flexDirection: 'row-reverse',
alignItems: 'center',
height: 24,
padding: theme.spacing(0.5),
paddingBottom: '5px', // optical alignment
fontFamily: lightTheme.typography.fontFamily,
Expand Down Expand Up @@ -678,9 +682,7 @@ const Root = styled('div')(
'& h1, & h2, & h3, & h4, & h5': {
color: `var(--muidocs-palette-grey-50, ${darkTheme.palette.grey[50]})`,
'& .anchor-icon, & .comment-link': {
color: `var(--muidocs-palette-primary-300, ${darkTheme.palette.primaryDark[300]})`,
borderColor: `var(--muidocs-palette-divider, ${darkTheme.palette.divider})`,
backgroundColor: alpha(darkTheme.palette.primaryDark[700], 0.5),
color: `var(--muidocs-palette-primary-300, ${darkTheme.palette.primaryDark[400]})`,
'&:hover': {
color: `var(--muidocs-palette-primary-100, ${darkTheme.palette.primary[100]})`,
borderColor: `var(--muidocs-palette-primary-900, ${darkTheme.palette.primary[900]})`,
Expand Down
Loading