Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui] Support CssVarsTheme in responsiveFontSizes return type #42786

Merged
merged 4 commits into from
Jun 30, 2024
Merged

[material-ui] Support CssVarsTheme in responsiveFontSizes return type #42786

merged 4 commits into from
Jun 30, 2024

Conversation

ijxy
Copy link
Contributor

@ijxy ijxy commented Jun 29, 2024 •
edited by ZeeshanTamboli

Closes #42760

@ijxy
[material-ui] Support CssVarsTheme in responsiveFontSizes types (#42760)
6f6a355 
Signed-off-by: jxdp <32483798+jxdp@users.noreply.github.com>
@ijxy ijxy mentioned this pull request Jun 29, 2024
Closed
@ijxy ijxy changed the title [material-ui] Support CssVarsTheme in responsiveFontSizes types (#42760) [material-ui] Support CssVarsTheme in responsiveFontSizes types Jun 29, 2024
@ZeeshanTamboli ZeeshanTamboli added typescript package: material-ui Specific to @mui/material customization: theme Centered around the theming features enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge labels Jun 30, 2024
@mui-bot
Copy link

mui-bot commented Jun 30, 2024 •
edited

Netlify deploy preview

https://deploy-preview-42786--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fc982cc

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui] Support CssVarsTheme in responsiveFontSizes types [material-ui] Support CssVarsTheme in responsiveFontSizes return type Jun 30, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui] Support CssVarsTheme in responsiveFontSizes return type [material-ui] Support CssVarsTheme in responsiveFontSizes return type Jun 30, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jxdp Thanks for the contribution. I have also added type tests.

@ZeeshanTamboli ZeeshanTamboli merged commit d238f98 into mui:next Jun 30, 2024
24 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 30, 2024
@ijxy @ZeeshanTamboli @web-flow
[material-ui] Support CssVarsTheme in responsiveFontSizes return …
e775b63 
…type (#42786)

Signed-off-by: jxdp <32483798+jxdp@users.noreply.github.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 30, 2024
Merged
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@ijxy @ZeeshanTamboli @joserodolfofreitas
[material-ui] Support CssVarsTheme in responsiveFontSizes return …
b8293ee 
…type (mui#42786)

Signed-off-by: jxdp <32483798+jxdp@users.noreply.github.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
customization: theme Centered around the theming features enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@mui/material: incorrect responsiveFontSizes return type when using CssVarsTheme as input
3 participants
@ijxy @mui-bot @ZeeshanTamboli