-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove custom hooks from the mui-name-matches-component-name
linting rule
#42773
Conversation
Netlify deploy previewhttps://deploy-preview-42773--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Had to dig a bit more than needed to figure out what this does. If you're up for it, I'd suggest to update the README with a short description of what this rule is supposed to cover.
I can add it to the README, but checking its implementation changed in #42638 @siriwatknp does it mean that the rule will stop working with |
Nope, I reverted in #42817. It should work the same for MUI X. |
👌 awesome |
The config now lives on the X repo.
And these custom hooks are blocking the PigmentCSS migration on the pickers.