-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix git diff format in migration to v6 #42711
Conversation
Netlify deploy previewBundle size report |
if (event.key === 'Escape' && chipRef.current) { | ||
chipRef.current.blur(); | ||
if (event.key === 'Escape') { | ||
chipRef.current!.blur(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe React guarantees the ref to be defined, so this is harmful defensive logic.
<Grid | ||
- disableEqualOverflow | ||
- disableEqualOverflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code style (2 space tab)
```diff | ||
<Alert | ||
- components={{ CloseButton: CustomButton }} | ||
+ slots={{ closeButton: CustomButton }} | ||
- componentsProps={{ closeButton: { testid: 'test-id' } }} | ||
+ slots={{ closeButton: CustomButton }} | ||
+ slotProps={{ closeButton: { testid: 'test-id' } }} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git diff groups deletion and addition to make them easier to read. I believe here it's simple enough that we should stick to the better default.
I have noticed those reading https://github.com/mui/material-ui/blob/next/packages/mui-codemod/README.md and https://next--material-ui.netlify.app/material-ui/migration/migration-v5/.