[code-infra] Run react-17 and react-next workflows on the next branch
#42690
Conversation
Netlify deploy previewhttps://deploy-preview-42690--material-ui.netlify.app/ Bundle size report |
cherniavskii
force-pushed
the
run-react-workflows-on-next
branch
from
01f61a2
to
fd8994c
Compare
.circleci/config.yml
Outdated
| pnpm install | ||
| else | ||
| echo "pnpm install --no-frozen-lockfile" | ||
| pnpm install --no-frozen-lockfile |
There was a problem hiding this comment.
The useReactVersion script modifies resolutions in package.json, and it can't install dependencies without this flag.
If there were no changes done to package.json (git --no-pager diff HEAD) == "" ), the flag is not being passed.
There was a problem hiding this comment.
Would it make sense for the useReactVersion script to run pnpm install after it sets the resolutions? That would make the lockfile consistent with what's installed and this branching becomes unnecessary.
There was a problem hiding this comment.
Yeah, running useReactVersion without installing the dependencies does not make much sense anyway 👍🏻
| react-17: | ||
| when: | ||
| equal: [react-17, << pipeline.parameters.workflow >>] | ||
| jobs: |
There was a problem hiding this comment.
I had to duplicate the jobs here, I couldn't find a way to reuse them in CircleCI (the experience of configuring Circle CI is not great TBH 😅).
The whole point is that:
react-17 workflow can be triggered manually on any branch (e.g. in a PR) on demand through Circle CI.
react-17-cron workflow is triggered by a cron job (same as before this PR).
Same for react-next workflows.
There was a problem hiding this comment.
Yeah, it's not great. Perhaps an orb could fix duplication here, but I don't really mind it so much.
| @@ -937,6 +988,7 @@ workflows: | |||
| branches: | |||
| only: | |||
| - master | |||
| - next | |||
There was a problem hiding this comment.
Added next branch here for the typescript-next workflow as well.
| - test_unit: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_unit-react@next |
There was a problem hiding this comment.
Added names here to avoid confusing job names, like this:
There was a problem hiding this comment.
I'm not sure why these ghost jobs appear though:
Perhaps it's a lag on the CircleCI side.
There was a problem hiding this comment.
Maybe it got in a bad state after renaming those jobs? Maybe try opening a different PR?
There was a problem hiding this comment.
Tried in #42991 and the result is the same...
There was a problem hiding this comment.
I believe circleci reuses some existing state when opening a PR for the same commit. At least I think I've observed that before. Trying out that hypothesis in mui/mui-x#13942
There was a problem hiding this comment.
Thanks, that seems to work!
I'll trigger the react-next workflow to make sure everything works as expected.
There was a problem hiding this comment.
All looks good now!
Any objections to merging current PR?
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Currently, the
react-17andreact-nextworkflows are scheduled to run every day on themasterbranch.Since
nextis now an active development branch, they should also be run on thenextbranch.The
react-nextworkflow on themasterbranch fails: https://app.circleci.com/pipelines/github/mui/material-ui/131952It cannot install dependencies, so I added the
--frozen-lockfileflag to thepnpm installcommand.Finally, both
react-17andreact-nextworkflows can be run on demand using the CircleCI "Trigger pipeline".