Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Add some writing tweaks to v6 migration page #42623

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jun 11, 2024

Some quick/small improvement opportunities I saw here!
https://deploy-preview-42623--material-ui.netlify.app/material-ui/migration/migration-v5/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material v6.x migration labels Jun 11, 2024
@danilo-leal danilo-leal self-assigned this Jun 11, 2024
@mui-bot
Copy link

mui-bot commented Jun 11, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e28868d

@siriwatknp
Copy link
Member

@danilo-leal Would you mind applying the change to #42242?

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danilo-leal
Copy link
Contributor Author

I'll just wait for Sam's review before either merging this directly (I don't think there will be a lot of conflicts with your PR, Jun! @siriwatknp) or just pushing these changes on Jun's PR.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 25, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 25, 2024
@danilo-leal
Copy link
Contributor Author

I'll merge this as it's just tiny changes!

@danilo-leal danilo-leal merged commit 968facc into mui:next Jun 27, 2024
19 checks passed
@danilo-leal danilo-leal deleted the migration-to-v6-writing-tweaks branch June 27, 2024 10:15
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material v6.x migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants