Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix Toolpad Core API links #42362

Merged
merged 1 commit into from
May 24, 2024

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented May 23, 2024

I just added automatic generation of API docs pages for the Toolpad Core components in mui/mui-toolpad#3536.
I adapted the scripts that most of the MUI libraries are using for that, but the API links are broken.
I guess we need to add this change to the markdown package to fix it?

@apedroferreira apedroferreira added the scope: docs-infra Specific to the docs-infra product label May 23, 2024
@apedroferreira apedroferreira marked this pull request as draft May 23, 2024 17:35
@mui-bot
Copy link

mui-bot commented May 23, 2024

Netlify deploy preview

https://deploy-preview-42362--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f7f7f3e

@apedroferreira apedroferreira marked this pull request as ready for review May 23, 2024 17:39
@apedroferreira apedroferreira requested a review from a team May 23, 2024 17:40
@danilo-leal danilo-leal changed the title Fix Toolpad Core API links [docs-infra] Fix Toolpad Core API links May 23, 2024
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you test on toolpad repo it's working as expected?

@apedroferreira
Copy link
Member Author

Looks good. Did you test on toolpad repo it's working as expected?

Actually I hadn't checked, yeah this fixes it!

@apedroferreira apedroferreira merged commit f0db205 into mui:next May 24, 2024
19 checks passed
@apedroferreira apedroferreira deleted the fix-toolpad-core-api-links branch May 24, 2024 13:48
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product Toolpad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants