Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][TableSortLabel] Deprecate composed classes #42281

Merged
merged 11 commits into from
Jun 14, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 17, 2024

part of #41282

@sai6855 sai6855 added component: table This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material package: codemod Specific to @mui/codemod labels May 17, 2024
@mui-bot
Copy link

mui-bot commented May 17, 2024

@@ -26,6 +34,8 @@ const tableSortLabelClasses: TableSortLabelClasses = generateUtilityClasses('Mui
'icon',
'iconDirectionDesc',
'iconDirectionAsc',
'directionDesc',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new classes

});

it('when given direction asc should have asc direction class', () => {
const { container } = render(<TableSortLabel direction="asc" />);
const icon = container.querySelector(`.${classes.icon}`);
expect(icon).not.to.have.class(classes.iconDirectionDesc);
expect(icon).to.have.class(classes.iconDirectionAsc);
expect(container.firstChild).to.have.class(classes.directionAsc);
expect(container.querySelector(`.${classes.directionAsc} > .${classes.icon}`)).not.equal(
Copy link
Contributor Author

@sai6855 sai6855 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to make sure replacement selector is actually working

@sai6855 sai6855 requested a review from DiegoAndai May 17, 2024 19:07
@sai6855 sai6855 changed the title [material-ui][TableSortLabel] Deprecate-composed-classes [material-ui][TableSortLabel] Deprecate composed classes May 17, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 20, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 23, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
@sai6855
Copy link
Contributor Author

sai6855 commented May 29, 2024

Not sure about argos failure, don't think they are related to this PR

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sai6855, thanks for working on this, sorry for the delay in the review.

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sai6855 🚀

@DiegoAndai DiegoAndai merged commit d32a8ce into mui:next Jun 14, 2024
22 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! deprecation New deprecation message package: codemod Specific to @mui/codemod package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants