-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Modal] migrate useSlotProps to useSLot #42150
Merged
Merged
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
243fcd7
initial setup
sai6855 40aef6c
initial setup
sai6855 36d94d9
fix typo
sai6855 6a85d1d
add types
sai6855 b8a2f1b
docs:api
sai6855 ffcc662
typo
sai6855 b7e45f1
chore: Remove unused code in Modal.js and Modal.test.js
sai6855 f9d91d7
fix tests
sai6855 63b159b
fix errors
sai6855 b917c00
fix errors
sai6855 a7f122a
Merge branch 'next' into deprecta-modal-componentprops
sai6855 ee945b8
fix callback issue
sai6855 8071c6f
fix
sai6855 c614d73
fix call back issue
sai6855 6b8fd4f
revert-changes
sai6855 7063ac0
trigger
sai6855 a20e49f
fix
sai6855 980ea1a
fix
sai6855 b7aa23e
fix tests
sai6855 07e2627
Merge branch 'next' into deprecta-modal-componentprops
sai6855 f7a2329
refactor
sai6855 c5066a8
Merge branch 'deprecta-modal-componentprops' of https://github.com/sa…
sai6855 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,6 @@ describe('<Modal />', () => { | |
'themeDefaultProps', // portal, can't determine the root | ||
'themeStyleOverrides', // portal, can't determine the root | ||
'reactTestRenderer', // portal https://github.com/facebook/react/issues/11565 | ||
'slotPropsCallback', // not supported yet | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. proof of slotPropsCallback is working |
||
], | ||
}), | ||
); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be?:
This would allow us to remove the
rootSlotProps
andbackdropSlotProps
variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiegoAndai refactored in this commit f7a2329, PR is now ready for next review