Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Add design and formatting improvements #42063

Merged
merged 14 commits into from
May 7, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 29, 2024

Tried to separate each little addition in individual/focused commits.

It can seem like a lot of changes, but most of them are changing the copywriting regarding migrating from deprecated APIs, which are found in several components (done in this commit 88d6d4a).

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Apr 29, 2024
@danilo-leal danilo-leal self-assigned this Apr 29, 2024
@mui-bot
Copy link

mui-bot commented Apr 29, 2024

Netlify deploy preview

https://deploy-preview-42063--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ed3ae94

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 2, 2024
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 2, 2024
@danilo-leal
Copy link
Contributor Author

Quick bump on this one, so y'all double-check it! :)

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise, it looks good!

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated How to migrate messages look good. Nit: some of them ended up with duplicated periods due to preceding inconsistencies: Before this change, some of the "How to migrate" messages had a period while others didn't.

packages/mui-material/src/Slider/Slider.js Outdated Show resolved Hide resolved
*/
TransitionComponent?: React.JSXElementConstructor<
TransitionProps & { children?: React.ReactElement<any, any> }
>;
/**
* Props applied to the transition element.
* By default, the element is based on this [`Transition`](https://reactcommunity.org/react-transition-group/transition/) component.
* @deprecated Use `slotProps.transition` instead. This prop will be removed in v7. [How to migrate](/material-ui/migration/migrating-from-deprecated-apis/).
* @deprecated Use `slotProps.transition` instead. This prop will be removed in v7. See [Migrating from deprecated APIs](/material-ui/migration/migrating-from-deprecated-apis/) for more details..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sai6855, may I ask you to apply this change to your open PRs?

@danilo-leal danilo-leal merged commit efba47d into mui:next May 7, 2024
22 checks passed
@danilo-leal danilo-leal deleted the docs-infra-design-improvements branch May 7, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants