Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix code block design by changing the MarkdownElement import #42022

Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 25, 2024

This PR fixes a bug that was introduced after #41859 where all MarkdownElement imports were replaced by the version of this component that now lives in the @mui/docs package. The marketing site pages should use a different version of this component, yet with the same name, which doesn't have some CSS properties from "the original" that mess up with the showcase section's design.

This PR is also a follow-up to a previous one (#42011), where I tried to fix this problem and improve the whole thing by removing the duplicate MarkdownElement components. In there, we concluded that it was best to have two PRs rather than one doing two things. This is part one. The second part will follow right after.

@danilo-leal danilo-leal added bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Apr 25, 2024
@danilo-leal danilo-leal self-assigned this Apr 25, 2024
@mui-bot
Copy link

mui-bot commented Apr 25, 2024

Netlify deploy preview

https://deploy-preview-42022--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 382eb87

@danilo-leal danilo-leal changed the title [website] Fix code block design by chnanging the MarkdownElement import [website] Fix code block design by changing the MarkdownElement import Apr 25, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, your follow-up PR intends to remove docs/src/components/markdown/MarkdownElement altogether, right?

@danilo-leal
Copy link
Contributor Author

If I understand correctly, your follow-up PR intends to remove docs/src/components/markdown/MarkdownElement altogether, right?

Yup — planning to go the route I explored on #42011 to pull that off.

@danilo-leal danilo-leal merged commit 341a6d2 into mui:next Apr 25, 2024
19 checks passed
@danilo-leal danilo-leal deleted the fix-markdownelement-import-regression-website branch April 25, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants