Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui][templates] Fix input props attributes in Landing Page template #42013

Merged
merged 3 commits into from
Apr 27, 2024
Merged

[docs][material-ui][templates] Fix input props attributes in Landing Page template #42013

merged 3 commits into from
Apr 27, 2024

Conversation

5-tom
Copy link
Contributor

@5-tom 5-tom commented Apr 24, 2024 •
edited
Loading

I encountered these 2 errors when using the landing page template:

'Warning: Invalid DOM property autocomplete. Did you mean autoComplete?'
'Warning: Invalid ARIA attribute ariaLabel. Did you mean aria-label?'

@mui-bot
Copy link

mui-bot commented Apr 24, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42013--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 53356d7

@5-tom 5-tom changed the title Use keys autoComplete and aria-label for TextField inputProps [docs] Use keys autoComplete and aria-label for TextField inputProps Apr 24, 2024
@zannager zannager added docs Improvements or additions to the documentation component: text field This is the name of the generic UI component, not the React module! labels Apr 24, 2024
@zannager zannager requested a review from zanivan April 24, 2024 16:04
@ZeeshanTamboli ZeeshanTamboli added package: material-ui Specific to @mui/material and removed component: text field This is the name of the generic UI component, not the React module! labels Apr 27, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Use keys autoComplete and aria-label for TextField inputProps [docs][material-ui][templates] Fix input props attributes in Landing Page template Apr 27, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Apr 27, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 842f1a6 into mui:next Apr 27, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 27, 2024
@5-tom @ZeeshanTamboli @web-flow
[docs][material-ui][templates] Fix input props attributes in Landing …
e8e704b 
…Page template (#42013)

Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
@github-actions github-actions bot mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@zanivan zanivan Awaiting requested review from zanivan

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@5-tom @mui-bot @ZeeshanTamboli @zannager