Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Use the getLayout on the material demo pages #41936

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Apr 17, 2024

It seems to speed up a bit the page transition.

I recoded the time between the click and the first frame with the new page content as follow

Screenshot from 2024-04-17 14-19-18

Result

The rendering time in ms

mui.com deploy-preview-41936--material-ui.netlify.app/
Alert 400 300
Backdrop 200 150
Dialog 350 300

@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Apr 17, 2024
@mui-bot
Copy link

mui-bot commented Apr 17, 2024

Netlify deploy preview

https://deploy-preview-41936--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9f7e66a

@alexfauquette alexfauquette marked this pull request as ready for review April 17, 2024 12:24
@alexfauquette alexfauquette requested a review from a team April 17, 2024 12:24
@alexfauquette alexfauquette changed the title [docs-infra][Draft] Text the impact of using the getLayout on the material demos [docs-infra] Use the getLayout on the material demo pages Apr 17, 2024
@bharatkashyap
Copy link
Member

@alexfauquette What are the two condition changes doing here? Might be useful to add a comment as well, or link to a comment on this PR 😄

@alexfauquette
Copy link
Member Author

@bharatkashyap I don't know why it was still visible. It comes from this PR #41908

@alexfauquette alexfauquette merged commit 78c0a66 into mui:next Apr 18, 2024
19 checks passed
@alexfauquette alexfauquette deleted the migrate-material-to-v2 branch April 18, 2024 13:08
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 22, 2024

Linking with #41117

Even beyond the improved performance, I appreciate the badge and search icon who do no longer flicker on each page transition. It will be great to propage this to all pages. It's nice we do it incrementally. We will see if there are more regressions. I had to fix a bunch in the past with the "v2".

@oliviertassinari oliviertassinari changed the title [docs-infra] Use the getLayout on the material demo pages [docs] Use the getLayout on the material demo pages Apr 22, 2024
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Apr 22, 2024
@alexfauquette
Copy link
Member Author

We will see if there are more regressions.

Only if someone uses next.mui.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material performance scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants