Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Typography] Fix ownerState prop placement #41903

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 15, 2024

Internal ownerState should always take over ownerState passed through props

@sai6855 sai6855 added component: Typography The React component. package: material-ui Specific to @mui/material labels Apr 15, 2024
@sai6855 sai6855 changed the title [material-ui][Typography] Fix ownerState prop placement in Typography component [material-ui][Typography] Fix ownerState prop placement Apr 15, 2024
@mui-bot
Copy link

mui-bot commented Apr 15, 2024

Netlify deploy preview

https://deploy-preview-41903--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 7ebb026

@DiegoAndai
Copy link
Member

@siriwatknp adding you as a reviewer as the owner of the Typography component.

This fix was found and required for: #41767 (comment)
Similar to: #40653

@sai6855
Copy link
Contributor Author

sai6855 commented Apr 22, 2024

@DiegoAndai can you merge this as it's blocking other pr

@DiegoAndai DiegoAndai merged commit 3316379 into mui:next Apr 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Typography The React component. package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants