Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Button] Add onChange event handler to file upload example #41863

Merged
merged 1 commit into from
Apr 13, 2024
Merged

[material-ui][Button] Add onChange event handler to file upload example #41863

merged 1 commit into from
Apr 13, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Apr 11, 2024 •
edited
Loading

Adding an onChange event handler to the "File upload" Button example after receiving this feedback:

For file upload example, there is no code that handles the upload event (i.e. doing something with the file.) I'm stuck on this at the moment.

Also making the input multiple.

@aarongarciah aarongarciah added docs Improvements or additions to the documentation component: button This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Apr 11, 2024
@aarongarciah aarongarciah marked this pull request as ready for review April 11, 2024 22:19
@aarongarciah aarongarciah reopened this Apr 11, 2024
@aarongarciah
Copy link
Member Author

aarongarciah commented Apr 11, 2024 •
edited
Loading

@DiegoAndai any idea why the "Check for duplicated packages" started to fail?

Edit: it's solved now.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 12, 2024
@mui-bot
Copy link

mui-bot commented Apr 12, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41863--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2e9934d

@siriwatknp siriwatknp force-pushed the aarongarciah/button-improve-file-upload-example branch from d9c995d to 3e54754 Compare April 12, 2024 06:30
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 12, 2024
@aarongarciah aarongarciah force-pushed the aarongarciah/button-improve-file-upload-example branch from 3e54754 to d9c995d Compare April 12, 2024 06:44
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 12, 2024
@aarongarciah aarongarciah force-pushed the aarongarciah/button-improve-file-upload-example branch from d9c995d to 745281a Compare April 12, 2024 06:45
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 12, 2024
@aarongarciah aarongarciah force-pushed the aarongarciah/button-improve-file-upload-example branch from 745281a to be2772d Compare April 12, 2024 06:58
@aarongarciah aarongarciah force-pushed the aarongarciah/button-improve-file-upload-example branch from be2772d to 2e9934d Compare April 12, 2024 12:29
DiegoAndai
DiegoAndai approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition 🎉

@aarongarciah aarongarciah merged commit 2fd1473 into mui:next Apr 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongarciah @mui-bot @DiegoAndai