Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Radio] Convert to support CSS extraction #41840

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

lhilgert9
Copy link
Contributor

Part of #41273.

Convert Radio and RadioButtonIcon to support CSS extraction.
Bildschirmfoto 2024-04-10 um 18 26 03
Bildschirmfoto 2024-04-10 um 18 26 15
Bildschirmfoto 2024-04-10 um 18 26 32
Bildschirmfoto 2024-04-10 um 18 26 47

@mui-bot
Copy link

mui-bot commented Apr 10, 2024

Netlify deploy preview

https://deploy-preview-41840--material-ui.netlify.app/

packages/material-ui/material-ui.production.min.js: parsed: +0.08% , gzip: +0.07%
Radio: parsed: +0.46% , gzip: +0.18%
@material-ui/core: parsed: +0.07% , gzip: +0.02%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against e456a0f

@lhilgert9 lhilgert9 marked this pull request as ready for review April 12, 2024 14:45
@zannager zannager added component: radio This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Apr 15, 2024
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the help!

@siriwatknp siriwatknp enabled auto-merge (squash) April 18, 2024 05:24
@siriwatknp
Copy link
Member

@lhilgert9 Do you want to take Checkbox next? It's pretty similar to Radio.

@lhilgert9
Copy link
Contributor Author

@lhilgert9 Do you want to take Checkbox next? It's pretty similar to Radio.

@siriwatknp Yes, you can assign me to the Checkbox👌🏼
Could you also mark ToggleButton as finished in #41273?

@siriwatknp siriwatknp merged commit deefd76 into mui:next Apr 18, 2024
19 checks passed
@lhilgert9 lhilgert9 deleted the radio-css-extraction branch April 22, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: radio This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants