[material-ui] Convert LinearProgress to support Pigment CSS
#41816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: LinearProgress
62 tasks
Netlify deploy previewhttps://deploy-preview-41816--material-ui.netlify.app/ @material-ui/core: parsed: +0.23% , gzip: +0.15% Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
force-pushed
the
mui/linear-progress
branch
from
3bcd4f1
to
2af9c1f
Compare
brijeshb42
reviewed
Apr 9, 2024
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
siriwatknp
commented
Apr 11, 2024
siriwatknp
commented
Apr 12, 2024
Comment on lines
+45
to
+50
| const rotateAnimation = | ||
| typeof circularRotateKeyframe !== 'string' | ||
| ? css` | ||
| animation: ${circularRotateKeyframe} 1.4s linear infinite; | ||
| ` | ||
| : null; |
There was a problem hiding this comment.
I decided to move the logic here so that rotateAnimation is not generated for Pigment CSS since the keyframe is already enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41273
Screen.Recording.2567-04-09.at.15.12.48.mov