[pigment-css][nextjs] Allow usage of url() CSS function #41758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41758--material-ui.netlify.app/ Bundle size report |
siriwatknp
reviewed
Apr 4, 2024
siriwatknp
reviewed
Apr 4, 2024
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
pigment/nextjs-url-fn
branch
from
52393b4
to
f7c98a0
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
force-pushed
the
pigment/nextjs-url-fn
branch
from
f7c98a0
to
2d88612
Compare
|
I assume that this PR will work with image import as well, right? given that the framework will replace the image with a string. import image from '../../path/to/image';
<body
className={css`background: url(${image});`}
/> |
|
True |
in styled/css definitions. This change goes a step further and allows you to reference files using configured aliases that you can't do in plain CSS files in Next.js
brijeshb42
force-pushed
the
pigment/nextjs-url-fn
branch
from
cd3d4ca
to
dc6ed93
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in styled/css definitions. This change goes a step further and allows you to reference files using configured aliases that you can't do in plain CSS files in Next.js