[pigment-css] Fix propTypes removal during eval stage #41695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditional assignment of propTypes was not handled resulting in error while using prod builds of material-ui.
Netlify deploy previewhttps://deploy-preview-41695--material-ui.netlify.app/ Bundle size report |
siriwatknp
reviewed
Mar 29, 2024
Comment on lines
+39
to
+52
| export function App() { | ||
| return ( | ||
| <Component> | ||
| <SliderRail /> | ||
| <SliderRail2 /> | ||
| </Component> | ||
| ); | ||
| } | ||
|
|
||
| process.env.NODE_ENV !== 'production' | ||
| ? (App.propTypes = { | ||
| children: PropTypes.element, | ||
| }) | ||
| : void 0; |
There was a problem hiding this comment.
What would happen if the propTypes are not handled? I guess the test will throw during evaluation?
There was a problem hiding this comment.
During evaluation, App gets set to null. So we are setting a value to null object resulting in the error.
App = null;
App.propTypes = {}
siriwatknp
approved these changes
Mar 29, 2024
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 29, 2024
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditional assignment of propTypes was not handled resulting in error while using prod builds of material-ui.