[pigment-css] Fix props forwarding #41688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/styled-forward-prop
…t/styled-forward-prop
brijeshb42
reviewed
Mar 28, 2024
| ); | ||
| const newProps = {}; | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| for (const key in props) { |
There was a problem hiding this comment.
I hope this is comparatively faster than Object.keys since optimizing this styled call is the most important part as it'll be called a lot.
There was a problem hiding this comment.
I think so, it's the same logic as emotion.
There was a problem hiding this comment.
styled-component also do the same.
siriwatknp
commented
Mar 28, 2024
Comment on lines
+33
to
+35
| loader: { | ||
| '.js': 'jsx', | ||
| }, |
There was a problem hiding this comment.
Added this after switching styled.jsx to styled.js to make the build work. I can't run the test with .jsx and there is no .jsx found the codebase.
Netlify deploy previewhttps://deploy-preview-41688--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
brijeshb42
approved these changes
Mar 28, 2024
mnajdova
approved these changes
Mar 28, 2024
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 29, 2024
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock #41378
@emotion/is-prop-validshouldForwardPropfor root and other slots