Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Fix typo on the Accordion page #41687

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[material-ui][docs] Fix typo on the Accordion page #41687

merged 2 commits into from
Mar 27, 2024

Conversation

connorshea
Copy link
Contributor

@danilo-leal danilo-leal changed the title Update accordion.md to fix typo [material-ui][docs] Fix typo on the Accordion page Mar 27, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: accordion This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Mar 27, 2024
danilo-leal
danilo-leal approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@danilo-leal danilo-leal enabled auto-merge (squash) March 27, 2024 18:32
@danilo-leal danilo-leal changed the base branch from master to next March 27, 2024 18:32
@connorshea
Copy link
Contributor Author

Should I rebase this change on top of next to avoid the merge conflicts/extra commits?

@danilo-leal
Copy link
Contributor

Yeah, please! 😬 Was about to do that myself in a few, but go ahead!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 27, 2024
@connorshea
Update accordion.md to fix typo
cb3d013 
Signed-off-by: Connor Shea <connor.james.shea@gmail.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 27, 2024
@connorshea
Copy link
Contributor Author

Updated 👍

@danilo-leal danilo-leal enabled auto-merge (squash) March 27, 2024 18:56
@connorshea
Copy link
Contributor Author

hmm, do I need to do anything specific to get the remaining tests to run?

@mui-bot
Copy link

mui-bot commented Mar 27, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b216087

@danilo-leal danilo-leal merged commit e803543 into mui:next Mar 27, 2024
18 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 29, 2024
@connorshea @mnajdova
[material-ui][docs] Fix typo on the Accordion page (mui#41687)
ade89ba
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
@connorshea @tejasparkar
[material-ui][docs] Fix typo on the Accordion page (mui#41687)
bed5614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: accordion This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorshea @danilo-leal @mui-bot