Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Fix require.context with aliases #41682

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 27, 2024

Noticed while working on mui/mui-x#12232

require.context returns all possible requests that can be made. req.keys() returns

[ './translations.json', 'docs/translations/translations.json' ]

after the change it returns

[ './translations.json' ]

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Mar 27, 2024
@mui-bot
Copy link

mui-bot commented Mar 27, 2024

Netlify deploy preview

https://deploy-preview-41682--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 544eed0

@Janpot Janpot marked this pull request as ready for review March 27, 2024 11:54
@Janpot Janpot requested a review from a team March 27, 2024 11:54
@Janpot Janpot merged commit 097a7e0 into mui:next Apr 12, 2024
20 checks passed
@Janpot Janpot deleted the contextt branch April 12, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants