Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][ButtonGroup] Convert to support CSS extraction #41666

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Mar 26, 2024

Part of #41273

image

@zanivan zanivan added package: material-ui Specific to @mui/material component: ButtonGroup The React component. package: pigment-css Specific to @pigment-css/* labels Mar 26, 2024
@zanivan zanivan self-assigned this Mar 26, 2024
@mui-bot
Copy link

mui-bot commented Mar 26, 2024

Netlify deploy preview

https://deploy-preview-41666--material-ui.netlify.app/

@material-ui/core: parsed: +0.09% , gzip: +0.05%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against fb89ea9

@zanivan zanivan requested a review from siriwatknp March 26, 2024 18:23
@zanivan zanivan marked this pull request as ready for review March 26, 2024 18:23
siriwatknp

This comment was marked as outdated.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there are Argos changes, meaning the styles are not the same.

@zanivan zanivan requested a review from siriwatknp March 27, 2024 21:58
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work!

@zanivan
Copy link
Contributor Author

zanivan commented Mar 28, 2024

@siriwatknp there's a test failing, it seems that it's due to LoadingButtonGroup.tsx. Do you know how it can be fixed?

@siriwatknp siriwatknp merged commit 5a289eb into mui:next Mar 29, 2024
19 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 29, 2024
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ButtonGroup The React component. package: material-ui Specific to @mui/material package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants