Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update peerDependencies ranges to include v6 packages #41662

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Mar 26, 2024

  • Adds a missing @mui/material dev dependency to @mui/lab
  • Updates peer dep version ranges in @mui/material-nextjs and @mui/lab

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Mar 26, 2024
@mui-bot
Copy link

mui-bot commented Mar 26, 2024

Netlify deploy preview

https://deploy-preview-41662--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against eb2c5c4

@michaldudak michaldudak changed the title [lab] Add devDependency to Material UI [core] Update peerDependencies ranges to include v6 packages Mar 26, 2024
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@michaldudak michaldudak marked this pull request as ready for review March 26, 2024 13:18
@michaldudak michaldudak enabled auto-merge (squash) March 26, 2024 13:20
@@ -50,7 +50,7 @@
"peerDependencies": {
"@emotion/cache": "^11.11.0",
"@emotion/server": "^11.11.0",
"@mui/material": "^5.0.0",
"@mui/material": "workspace:^",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a peer dependency. Perhaps we need to add a dev dependency with "workspace:^"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was on purpose. @mui/material is not actually used in development, so there's no need to have in devDependencies.
(technically, I don't think it's required to have it in peer dependencies either, but that's another topic)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd either keep it in peer dependencies and add a dev dependency to make the lockfile sound, or just remove it from peer dependencies altogether

@michaldudak michaldudak merged commit 49bd994 into mui:next Mar 26, 2024
19 checks passed
@michaldudak michaldudak deleted the restore-lab-dependency branch March 26, 2024 13:53
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants