[lab][TabPanel] Add keepMounted prop to match joy-ui #41651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41651--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
zannager
added
component: tabs
|
Base UI development was moved to a separate repository: https://github.com/mui/base-ui. We don't accept contributions in this repo anymore. As the Tabs are undergoing API change (mui/base-ui#245), we will consider adding your proposed prop. The Lab implementation looks OK to me. |
|
I'll revert the base-ui changes to leave only the labs proposal 👍 |
ppaskaris-plooto
force-pushed
the
add-keep-mounted-prop-to-labs-tabpanel
branch
from
9c715ec
to
b469e8e
Compare
ppaskaris-plooto
changed the title
michaldudak
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
keepMountedprop to the labs implementations ofTabPanel, bringing it into alignment with the implementation in joy-ui. It also adds a-hiddenclass, aligning it with both base-ui and joy-ui for easier styling/theming now that the children can be present in the DOM when the tabpanel is not active.Fixes #37398
Fixes #38178
I am only addressing the immediate absence of this prop compared to joy-ui, and not trying to solve for the broader issue described in #21250.