Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment-css][docs] Edit the example app's README files #41639

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Mar 25, 2024

Found these quick-win improvement opportunities as I was setting up a new test project. Not a super critical review, but I'm curious whether the command pnpm build:zero is still correct, though (after we changed the package's name)?

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/* labels Mar 25, 2024
@danilo-leal danilo-leal self-assigned this Mar 25, 2024
@mui-bot
Copy link

mui-bot commented Mar 25, 2024

Netlify deploy preview

https://deploy-preview-41639--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 61c8711

@danilo-leal
Copy link
Contributor Author

Just a quick bump here, as it's a simple one! :)

Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apps/pigment-css-next-app/README.md Outdated Show resolved Hide resolved
apps/pigment-css-next-app/README.md Outdated Show resolved Hide resolved
apps/pigment-css-vite-app/README.md Outdated Show resolved Hide resolved
apps/pigment-css-vite-app/README.md Outdated Show resolved Hide resolved
apps/pigment-css-vite-app/README.md Outdated Show resolved Hide resolved
apps/pigment-css-vite-app/README.md Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor Author

@samuelsycamore let me know if you still want to push in any changes here!

@samuelsycamore
Copy link
Member

@danilo-leal I'd say go ahead and 🚢 this—I'll circle back another time to iterate on it!

@danilo-leal danilo-leal merged commit 9854e18 into mui:next Apr 1, 2024
19 checks passed
@danilo-leal danilo-leal deleted the pigment-apps-readme-tweaks branch April 1, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants