Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Card] Convert to support CSS extraction #41580

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[material-ui][Card] Convert to support CSS extraction #41580

merged 1 commit into from
Mar 21, 2024

Conversation

aacevski
Copy link
Contributor

Hey @siriwatknp, I see the assets have not been moved to the docs, should we update the script to do that as well?

Screen.Recording.2024-03-20.at.20.17.56.mov

@mui-bot
Copy link

mui-bot commented Mar 20, 2024

Netlify deploy preview

https://deploy-preview-41580--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 606a087

@danilo-leal danilo-leal added component: card This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Mar 20, 2024
@mnajdova
Copy link
Member

Hey @siriwatknp, I see the assets have not been moved to the docs, should we update the script to do that as well?

I ignored this so far, it's not worth I think. We are anyway adding these example just to validate if it works, we are not going to actually use them as a docs.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

paddingBottom: 24,
},
};
})({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, no need for a callback 👍

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@siriwatknp siriwatknp merged commit 68ec7d7 into mui:next Mar 21, 2024
20 of 21 checks passed
pluvio72 pushed a commit to pluvio72/material-ui that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: card This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants